<?xml version="1.0"?>
<ownershipDocument>

    <schemaVersion>X0303</schemaVersion>

    <documentType>4</documentType>

    <periodOfReport>2009-01-02</periodOfReport>

    <issuer>
        <issuerCik>0000729922</issuerCik>
        <issuerName>OSI PHARMACEUTICALS INC</issuerName>
        <issuerTradingSymbol>OSIP</issuerTradingSymbol>
    </issuer>

    <reportingOwner>
        <reportingOwnerId>
            <rptOwnerCik>0001391045</rptOwnerCik>
            <rptOwnerName>Legault Pierre</rptOwnerName>
        </reportingOwnerId>
        <reportingOwnerAddress>
            <rptOwnerStreet1>C/O OSI PHARMACEUTICALS, INC.</rptOwnerStreet1>
            <rptOwnerStreet2>41 PINELAWN ROAD</rptOwnerStreet2>
            <rptOwnerCity>MELVILLE</rptOwnerCity>
            <rptOwnerState>NY</rptOwnerState>
            <rptOwnerZipCode>11747</rptOwnerZipCode>
            <rptOwnerStateDescription></rptOwnerStateDescription>
        </reportingOwnerAddress>
        <reportingOwnerRelationship>
            <isOfficer>1</isOfficer>
            <officerTitle>Exec. VP, CFO &amp; Treasurer</officerTitle>
        </reportingOwnerRelationship>
    </reportingOwner>

    <nonDerivativeTable>
        <nonDerivativeTransaction>
            <securityTitle>
                <value>Common Stock</value>
            </securityTitle>
            <transactionDate>
                <value>2009-01-02</value>
            </transactionDate>
            <transactionCoding>
                <transactionFormType>4</transactionFormType>
                <transactionCode>A</transactionCode>
                <equitySwapInvolved>0</equitySwapInvolved>
            </transactionCoding>
            <transactionTimeliness></transactionTimeliness>
            <transactionAmounts>
                <transactionShares>
                    <value>12500</value>
                    <footnoteId id="F1"/>
                </transactionShares>
                <transactionPricePerShare>
                    <value>0</value>
                </transactionPricePerShare>
                <transactionAcquiredDisposedCode>
                    <value>A</value>
                </transactionAcquiredDisposedCode>
            </transactionAmounts>
            <postTransactionAmounts>
                <sharesOwnedFollowingTransaction>
                    <value>12500</value>
                </sharesOwnedFollowingTransaction>
            </postTransactionAmounts>
            <ownershipNature>
                <directOrIndirectOwnership>
                    <value>D</value>
                </directOrIndirectOwnership>
            </ownershipNature>
        </nonDerivativeTransaction>
    </nonDerivativeTable>

    <derivativeTable>
        <derivativeTransaction>
            <securityTitle>
                <value>Stock Option (Right to Buy)</value>
            </securityTitle>
            <conversionOrExercisePrice>
                <value>39.77</value>
            </conversionOrExercisePrice>
            <transactionDate>
                <value>2009-01-02</value>
            </transactionDate>
            <transactionCoding>
                <transactionFormType>4</transactionFormType>
                <transactionCode>A</transactionCode>
                <equitySwapInvolved>0</equitySwapInvolved>
            </transactionCoding>
            <transactionTimeliness></transactionTimeliness>
            <transactionAmounts>
                <transactionShares>
                    <value>125000</value>
                </transactionShares>
                <transactionPricePerShare>
                    <value>39.77</value>
                </transactionPricePerShare>
                <transactionAcquiredDisposedCode>
                    <value>A</value>
                </transactionAcquiredDisposedCode>
            </transactionAmounts>
            <exerciseDate>
                <value>2012-01-02</value>
                <footnoteId id="F2"/>
            </exerciseDate>
            <expirationDate>
                <value>2016-01-01</value>
            </expirationDate>
            <underlyingSecurity>
                <underlyingSecurityTitle>
                    <value>Common Stock</value>
                </underlyingSecurityTitle>
                <underlyingSecurityShares>
                    <value>125000</value>
                </underlyingSecurityShares>
            </underlyingSecurity>
            <postTransactionAmounts>
                <sharesOwnedFollowingTransaction>
                    <value>125000</value>
                    <footnoteId id="F3"/>
                </sharesOwnedFollowingTransaction>
            </postTransactionAmounts>
            <ownershipNature>
                <directOrIndirectOwnership>
                    <value>D</value>
                </directOrIndirectOwnership>
            </ownershipNature>
        </derivativeTransaction>
    </derivativeTable>

    <footnotes>
        <footnote id="F1">Represents the Restricted Stock Unit component of the equity compensation awarded to Mr. Legault upon his appointment as an executive officer of the Company. 25% of the Restricted Stock Units vest one year after the date of grant and the remainder will vest ratably on an annual basis over the succeeding 3 years. Mr. Legault  will receive one share of OSI Common Stock for each vested Restricted Stock Unit that he holds.</footnote>
        <footnote id="F2">One third of the stock option grant will become exercisable on each of the third, fourth and fifth anniversaries of the grant date.</footnote>
        <footnote id="F3">Includes only options with the same termination date.</footnote>
    </footnotes>

    <ownerSignature>
        <signatureName>/s/ Pierre Legault</signatureName>
        <signatureDate>2009-01-05</signatureDate>
    </ownerSignature>
</ownershipDocument>
