<?xml version="1.0"?>
<ownershipDocument>

    <schemaVersion>X0303</schemaVersion>

    <documentType>4</documentType>

    <periodOfReport>2008-07-14</periodOfReport>

    <issuer>
        <issuerCik>0000729922</issuerCik>
        <issuerName>OSI PHARMACEUTICALS INC</issuerName>
        <issuerTradingSymbol>OSIP</issuerTradingSymbol>
    </issuer>

    <reportingOwner>
        <reportingOwnerId>
            <rptOwnerCik>0001220050</rptOwnerCik>
            <rptOwnerName>SIMON ROBERT L</rptOwnerName>
        </reportingOwnerId>
        <reportingOwnerAddress>
            <rptOwnerStreet1>C/O OSI PHARMACEUTICALS, INC.</rptOwnerStreet1>
            <rptOwnerStreet2>41 PINELAWN ROAD</rptOwnerStreet2>
            <rptOwnerCity>MELVILLE</rptOwnerCity>
            <rptOwnerState>NY</rptOwnerState>
            <rptOwnerZipCode>11747</rptOwnerZipCode>
            <rptOwnerStateDescription></rptOwnerStateDescription>
        </reportingOwnerAddress>
        <reportingOwnerRelationship>
            <isOfficer>1</isOfficer>
            <officerTitle>Exec. VP, Pharm. Dev. &amp; Manf.</officerTitle>
        </reportingOwnerRelationship>
    </reportingOwner>

    <nonDerivativeTable>
        <nonDerivativeTransaction>
            <securityTitle>
                <value>Common Stock</value>
            </securityTitle>
            <transactionDate>
                <value>2008-07-14</value>
            </transactionDate>
            <transactionCoding>
                <transactionFormType>4</transactionFormType>
                <transactionCode>F</transactionCode>
                <equitySwapInvolved>0</equitySwapInvolved>
            </transactionCoding>
            <transactionTimeliness></transactionTimeliness>
            <transactionAmounts>
                <transactionShares>
                    <value>388</value>
                    <footnoteId id="F1"/>
                </transactionShares>
                <transactionPricePerShare>
                    <value>44.72</value>
                </transactionPricePerShare>
                <transactionAcquiredDisposedCode>
                    <value>D</value>
                </transactionAcquiredDisposedCode>
            </transactionAmounts>
            <postTransactionAmounts>
                <sharesOwnedFollowingTransaction>
                    <value>30088</value>
                </sharesOwnedFollowingTransaction>
            </postTransactionAmounts>
            <ownershipNature>
                <directOrIndirectOwnership>
                    <value>D</value>
                </directOrIndirectOwnership>
            </ownershipNature>
        </nonDerivativeTransaction>
    </nonDerivativeTable>

    <footnotes>
        <footnote id="F1">On July 14, 2006, Mr. Simon was issued 5,000 shares of restricted stock by the company.  On July 14, 2008, 1,250 shares of the restricted stock vested.  Pursuant to the restricted stock agreement, Mr. Simon elected to satisfy his tax withholding obligation as a result of the vesting by surrendering a number of shares of common sotck having a value on the date of the exchange equal to the tax withholding obligation.  This form is being filed to reflect the surrender of 388 shares of common stock to satisfy the grantee's tax withholding obligation.</footnote>
    </footnotes>

    <ownerSignature>
        <signatureName>/s/ Michael G. Atieh, attorney-in-fact for Mr. Simon</signatureName>
        <signatureDate>2008-07-16</signatureDate>
    </ownerSignature>
</ownershipDocument>
