<?xml version="1.0"?>
<ownershipDocument>

    <schemaVersion>X0303</schemaVersion>

    <documentType>4</documentType>

    <periodOfReport>2010-01-25</periodOfReport>

    <issuer>
        <issuerCik>0000712770</issuerCik>
        <issuerName>ONE LIBERTY PROPERTIES INC</issuerName>
        <issuerTradingSymbol>OLP</issuerTradingSymbol>
    </issuer>

    <reportingOwner>
        <reportingOwnerId>
            <rptOwnerCik>0001187919</rptOwnerCik>
            <rptOwnerName>BIEDERMAN CHARLES</rptOwnerName>
        </reportingOwnerId>
        <reportingOwnerAddress>
            <rptOwnerStreet1>5 SUNSET DRIVE</rptOwnerStreet1>
            <rptOwnerStreet2></rptOwnerStreet2>
            <rptOwnerCity>ENGLEWOOD</rptOwnerCity>
            <rptOwnerState>C0</rptOwnerState>
            <rptOwnerZipCode>80110</rptOwnerZipCode>
            <rptOwnerStateDescription>UNITED ARAB EMIRATES</rptOwnerStateDescription>
        </reportingOwnerAddress>
        <reportingOwnerRelationship>
            <isDirector>1</isDirector>
            <isOfficer>0</isOfficer>
            <isTenPercentOwner>0</isTenPercentOwner>
            <isOther>0</isOther>
        </reportingOwnerRelationship>
    </reportingOwner>

    <nonDerivativeTable>
        <nonDerivativeTransaction>
            <securityTitle>
                <value>Common Stock</value>
            </securityTitle>
            <transactionDate>
                <value>2010-01-25</value>
            </transactionDate>
            <transactionCoding>
                <transactionFormType>4</transactionFormType>
                <transactionCode>J</transactionCode>
                <equitySwapInvolved>0</equitySwapInvolved>
            </transactionCoding>
            <transactionAmounts>
                <transactionShares>
                    <value>478</value>
                    <footnoteId id="F1"/>
                </transactionShares>
                <transactionPricePerShare>
                    <value>10.2046</value>
                </transactionPricePerShare>
                <transactionAcquiredDisposedCode>
                    <value>A</value>
                </transactionAcquiredDisposedCode>
            </transactionAmounts>
            <postTransactionAmounts>
                <sharesOwnedFollowingTransaction>
                    <value>22673</value>
                </sharesOwnedFollowingTransaction>
            </postTransactionAmounts>
            <ownershipNature>
                <directOrIndirectOwnership>
                    <value>D</value>
                </directOrIndirectOwnership>
                <natureOfOwnership>
                    <value></value>
                </natureOfOwnership>
            </ownershipNature>
        </nonDerivativeTransaction>
    </nonDerivativeTable>

    <footnotes>
        <footnote id="F1">As a result of the dividend declared on December 11, 2009 and paid on January 25, 2010 to all stockholders of record on     December 22, 2009, these additional shares were received by the reporting person.</footnote>
    </footnotes>

    <remarks></remarks>

    <ownerSignature>
        <signatureName>Charles L. Biederman by Simeon Brinberg, his attorney in fact</signatureName>
        <signatureDate>2010-01-27</signatureDate>
    </ownerSignature>
</ownershipDocument>
