CONDENSED CONSOLIDATED STATEMENTS OF COMPREHENSIVE INCOME (LOSS) - USD ($) $ in Thousands	3 Months Ended
	Mar. 31, 2025	Mar. 31, 2024
Statement of Comprehensive Income [Abstract]
Net income	$ 19,519	$ 95,088
Other comprehensive income (loss)
Unrealized (loss) gain on derivative contracts	(7,799)	20,413
Reclassification of other comprehensive income to interest expense	(3,232)	(9,314)
Other comprehensive (loss) income	(11,031)	11,099
Comprehensive income	8,488	106,187
Comprehensive income attributable to noncontrolling interests	(1,725)	(39,781)
Comprehensive income attributable to National Storage Affiliates Trust	$ 6,763	$ 66,406