Segments - Net Operating Income by Segment (Details) - USD ($) $ in Thousands	12 Months Ended
	Dec. 31, 2024	Dec. 31, 2023	Dec. 31, 2022
Segment Reporting, Reconciling Item for Operating Profit (Loss) from Segment to Consolidated [Line Items]
Income before income taxes	$ 187,037	$ 238,578	$ 188,454
General and administrative expenses	57,606	59,281	59,311
Depreciation and amortization	189,855	221,993	233,158
Other	13,866	11,108	8,537
Loss on early extinguishment of debt	323	758	0
Equity in losses (earnings) of unconsolidated real estate ventures	16,075	(7,553)	(7,745)
Non-operating income (expense)	(314)	1,016	951
Gain on sale of self storage properties	(63,841)	(63,910)	(5,466)
Management fees and other revenue
Segment Reporting, Reconciling Item for Operating Profit (Loss) from Segment to Consolidated [Line Items]
Revenue	(42,726)	(34,411)
Reportable Segment
Segment Reporting, Reconciling Item for Operating Profit (Loss) from Segment to Consolidated [Line Items]
Income before income taxes	187,037	238,578	188,454
General and administrative expenses	57,606	59,281	59,311
Depreciation and amortization	189,855	221,993	233,158
Other	13,866	11,108	8,537
Interest expense	154,260	166,147	110,599
Loss on early extinguishment of debt	323	758	0
Equity in losses (earnings) of unconsolidated real estate ventures	16,075	(7,553)	(7,745)
Acquisition and integration costs	3,616	1,659	2,745
Non-operating income (expense)	(314)	1,016	951
Gain on sale of self storage properties	(63,841)	(63,910)	(5,466)
Net operating income	515,757	594,666	562,920
Reportable Segment | Management fees and other revenue
Segment Reporting, Reconciling Item for Operating Profit (Loss) from Segment to Consolidated [Line Items]
Revenue	$ (42,726)	$ (34,411)	$ (27,624)