CONSOLIDATED STATEMENTS OF COMPREHENSIVE INCOME (LOSS) - USD ($) $ in Thousands	12 Months Ended
	Dec. 31, 2024	Dec. 31, 2023	Dec. 31, 2022
Statement of Comprehensive Income [Abstract]
Net income	$ 183,270	$ 236,988	$ 183,765
Other comprehensive income (loss)
Unrealized gain on derivative contracts	27,908	10,893	82,418
Realized loss on derivative contracts	0	(1,643)	0
Reclassification of other comprehensive (income) loss to interest expense	(31,779)	(35,605)	2,315
Other comprehensive (loss) income	(3,871)	(26,355)	84,733
Comprehensive income	179,399	210,633	268,498
Comprehensive income attributable to noncontrolling interests	(69,093)	(71,649)	(104,826)
Comprehensive income attributable to National Storage Affiliates Trust	$ 110,306	$ 138,984	$ 163,672