CONDENSED CONSOLIDATED STATEMENTS OF COMPREHENSIVE INCOME (LOSS) - USD ($) $ in Thousands	3 Months Ended		9 Months Ended
	Sep. 30, 2024	Sep. 30, 2023	Sep. 30, 2024	Sep. 30, 2023
Statement of Comprehensive Income [Abstract]
Net income	$ 29,771	$ 43,064	$ 157,139	$ 128,932
Other comprehensive income (loss)
Unrealized (loss) gain on derivative contracts	(21,234)	20,433	5,760	35,706
Realized loss on derivative contracts	0	0	0	(1,643)
Reclassification of other comprehensive income to interest expense	(7,813)	(9,018)	(26,449)	(26,239)
Other comprehensive (loss) income	(29,047)	11,415	(20,689)	7,824
Comprehensive income	724	54,479	136,450	136,756
Comprehensive loss (income) attributable to noncontrolling interests	1,668	(17,466)	(52,372)	(43,840)
Comprehensive income attributable to National Storage Affiliates Trust	$ 2,392	$ 37,013	$ 84,078	$ 92,916