CONDENSED CONSOLIDATED STATEMENTS OF COMPREHENSIVE INCOME (LOSS) - USD ($) $ in Thousands	3 Months Ended		6 Months Ended
	Jun. 30, 2024	Jun. 30, 2023	Jun. 30, 2024	Jun. 30, 2023
Statement of Comprehensive Income [Abstract]
Net income	$ 32,280	$ 45,476	$ 127,368	$ 85,868
Other comprehensive income (loss)
Unrealized gain on derivative contracts	6,581	28,226	26,994	15,273
Realized loss on derivative contracts	0	(1,643)	0	(1,643)
Reclassification of other comprehensive income to interest expense	(9,322)	(9,460)	(18,636)	(17,221)
Other comprehensive (loss) income	(2,741)	17,123	8,358	(3,591)
Comprehensive income	29,539	62,599	135,726	82,277
Comprehensive income attributable to noncontrolling interests	(14,259)	(21,493)	(54,040)	(26,374)
Comprehensive income attributable to National Storage Affiliates Trust	$ 15,280	$ 41,106	$ 81,686	$ 55,903