CONDENSED CONSOLIDATED STATEMENTS OF COMPREHENSIVE INCOME (LOSS) - USD ($) $ in Thousands	3 Months Ended
	Mar. 31, 2024	Mar. 31, 2023
Statement of Comprehensive Income [Abstract]
Net income	$ 95,088	$ 40,392
Other comprehensive income (loss)
Unrealized gain (loss) on derivative contracts	20,413	(12,953)
Reclassification of other comprehensive income to interest expense	(9,314)	(7,761)
Other comprehensive income (loss)	11,099	(20,714)
Comprehensive income	106,187	19,678
Comprehensive income attributable to noncontrolling interests	(39,781)	(4,881)
Comprehensive income attributable to National Storage Affiliates Trust	$ 66,406	$ 14,797