CONDENSED CONSOLIDATED STATEMENTS OF COMPREHENSIVE INCOME (LOSS) - USD ($) $ in Thousands	3 Months Ended
	Mar. 31, 2023	Mar. 31, 2022
Statement of Comprehensive Income [Abstract]
Net income	$ 40,392	$ 44,786
Other comprehensive income (loss)
Unrealized (loss) gain on derivative contracts	(12,953)	38,608
Reclassification of other comprehensive (income) loss to interest expense	(7,761)	4,974
Other comprehensive (loss) income	(20,714)	43,582
Comprehensive income	19,678	88,368
Comprehensive income attributable to noncontrolling interests	(4,881)	(32,341)
Comprehensive income attributable to National Storage Affiliates Trust	$ 14,797	$ 56,027