CONDENSED CONSOLIDATED STATEMENTS OF COMPREHENSIVE INCOME (LOSS) - USD ($) $ in Thousands	3 Months Ended
	Mar. 31, 2022	Mar. 31, 2021
Statement of Comprehensive Income [Abstract]
Net income	$ 44,786	$ 27,635
Other comprehensive income
Unrealized gain on derivative contracts	38,608	20,900
Reclassification of other comprehensive loss to interest expense	4,974	4,957
Other comprehensive income	43,582	25,857
Comprehensive income	88,368	53,492
Comprehensive income attributable to noncontrolling interests	(32,341)	(14,814)
Comprehensive income attributable to National Storage Affiliates Trust	$ 56,027	$ 38,678