Statements Of Comprehensive Income - USD ($) $ in Thousands	3 Months Ended		6 Months Ended
	Jun. 30, 2020	Jun. 30, 2019	Jun. 30, 2020	Jun. 30, 2019
Statements Of Comprehensive Income [Abstract]
Net income	$ 315,812	$ 371,456	$ 682,948	$ 739,134
Other comprehensive income (loss):
Aggregate foreign currency exchange loss	(14,426)	(6,796)	(18,596)	(916)
Adjust for aggregate foreign currency exchange loss (gain) included in net income	19,295	5,218	10,350	(2,573)
Other comprehensive income (loss)	4,869	(1,578)	(8,246)	(3,489)
Total comprehensive income	320,681	369,878	674,702	735,645
Allocation to noncontrolling interests	(889)	(1,400)	(1,869)	(2,557)
Comprehensive income allocable to Public Storage shareholders	$ 319,792	$ 368,478	$ 672,833	$ 733,088