CONSOLIDATED STATEMENTS OF EQUITY AND REDEEMABLE NONCONTROLLING INTERESTS - USD ($) $ in Thousands	Total	Total Public Storage Shareholders' Equity	Cumulative Preferred Shares	Common Shares	Paid-in Capital	Accumulated Deficit	Accumulated Other Comprehensive Loss	Noncontrolling Interests
Beginning balance at Dec. 31, 2018	$ 9,144,728	$ 9,119,478	$ 4,025,000	$ 17,413	$ 5,718,485	$ (577,360)	$ (64,060)	$ 25,250
Increase (Decrease) in Stockholders' Equity [Roll Forward]
Issuance of preferred shares	1,059,156	1,059,156	1,090,000		(30,844)
Redemption and shares called for redemption of preferred shares	(1,050,000)	(1,050,000)	(1,050,000)
Issuance of common shares in connection with share-based compensation	33,564	33,564		29	33,535
Share-based compensation expense, net of cash paid in lieu of common shares	13,671	13,671			13,671
Acquisition of noncontrolling interests	(35,000)	(23,913)			(23,913)			(11,087)
Contributions by noncontrolling interests	4,148							4,148
Net income	1,525,651	1,525,651				1,525,651
Net income allocated to noncontrolling interests	(5,117)	(5,117)				(5,117)		(5,117)
Distributions to:
Preferred shareholders	(210,179)	(210,179)				(210,179)
Noncontrolling interests	(6,672)							(6,672)
Common shareholders and restricted share unitholders	(1,398,570)	(1,398,570)				(1,398,570)
Other comprehensive income (loss)	(830)	(830)					(830)
Ending balance at Dec. 31, 2019	9,079,667	9,062,911	4,065,000	17,442	5,710,934	(665,575)	(64,890)	16,756
Beginning balance at Dec. 31, 2018	0
Ending balance at Dec. 31, 2019	0
Increase (Decrease) in Stockholders' Equity [Roll Forward]
Issuance of preferred shares	1,208,206	1,208,206	1,247,500		(39,294)
Redemption and shares called for redemption of preferred shares	(1,520,000)	(1,520,000)	(1,520,000)
Issuance of common shares in connection with share-based compensation	12,664	12,664		16	12,648
Share-based compensation expense, net of cash paid in lieu of common shares	22,845	22,845			22,845
Acquisition of noncontrolling interests	(33)	(32)			(32)			(1)
Contributions by noncontrolling interests	2,629							2,629
Net income	1,361,227	1,361,227				1,361,227
Net income allocated to noncontrolling interests	(4,014)	(4,014)				(4,014)		(4,014)
Distributions to:
Preferred shareholders	(207,068)	(207,068)				(207,068)
Noncontrolling interests	(5,366)							(5,366)
Common shareholders and restricted share unitholders	(1,399,361)	(1,399,361)				(1,399,361)
Other comprehensive income (loss)	21,489	21,489					21,489
Ending balance at Dec. 31, 2020	8,576,899	8,558,867	3,792,500	17,458	5,707,101	(914,791)	(43,401)	18,032
Ending balance at Dec. 31, 2020	0
Increase (Decrease) in Stockholders' Equity [Roll Forward]
Issuance of preferred shares	1,147,455	1,147,455	1,182,500		(35,045)
Redemption and shares called for redemption of preferred shares	(875,000)	(875,000)	(875,000)
Issuance of common shares in connection with share-based compensation	95,860	95,860		55	95,805
Share-based compensation expense, net of cash paid in lieu of common shares	54,492	54,492			54,492
Acquisition of noncontrolling interests	(692)	(686)			(686)			(6)
Contributions by noncontrolling interests	2,451							2,451
Net income	1,959,639	1,959,639				1,959,639
Net income allocated to noncontrolling interests	(6,376)	(6,376)				(6,376)		(5,906)
Distributions to:
Preferred shareholders	(186,579)	(186,579)				(186,579)
Noncontrolling interests	(6,271)							(6,271)
Common shareholders and restricted share unitholders	(1,402,309)	(1,402,309)				(1,402,309)
Other comprehensive income (loss)	(10,186)	(10,186)					(10,186)
Ending balance at Dec. 31, 2021	9,355,289	$ 9,335,177	$ 4,100,000	$ 17,513	$ 5,821,667	$ (550,416)	$ (53,587)	$ 20,112
Increase (Decrease) in Temporary Equity [Roll Forward]
Contributions by noncontrolling interests	68,170
Net income allocated to noncontrolling interests	470
Noncontrolling interests	(391)
Ending balance at Dec. 31, 2021	$ 68,249