Statements Of Equity - USD ($) $ in Thousands	Cumulative Preferred Shares [Member]	Common Shares [Member]	Paid-In Capital [Member]	Accumulated Deficit [Member]	Accumulated Other Comprehensive Loss [Member]	Total Public Storage Shareholders' Equity [Member]	Noncontrolling Interests [Member]	Total
Balances at Dec. 31, 2016	$ 4,367,500	$ 17,329	$ 5,609,768	$ (487,581)	$ (95,106)	$ 9,411,910	$ 29,744	$ 9,441,654
Issuance of preferred shares (Note 8)	580,000					561,177		561,177
Issuance of preferred shares (Note 8), adjustment to APIC			(18,823)
Redemption of preferred shares (Note 8)	(922,500)					(922,500)		(922,500)
Issuance of common shares in connection with share-based compensation (Note 10)		56	42,444			42,500		42,500
Share-based compensation expense, net of cash paid in lieu of common shares (Note 10)			22,711			22,711		22,711
Acquisition of noncontrolling interests			(7,701)			(7,701)	(6,724)	(14,425)
Contributions by noncontrolling interests							2,484	2,484
Net income				1,448,465		1,448,465		1,448,465
Net income allocated to noncontrolling interests				(6,248)		(6,248)	6,248	(6,248)
Distributions to equity holders:
Preferred shares (Note 8)				(236,535)		(236,535)		(236,535)
Noncontrolling interests							(7,392)	(7,392)
Common shareholders and restricted share unitholders ($8.00 per share)				(1,393,812)		(1,393,812)		(1,393,812)
Other comprehensive (loss) income (Note 2)					20,042	20,042		20,042
Balances at Dec. 31, 2017	4,025,000	17,385	5,648,399	(675,711)	(75,064)	8,940,009	24,360	8,964,369
Issuance of common shares in connection with share-based compensation (Note 10)		28	12,497			12,525		12,525
Share-based compensation expense, net of cash paid in lieu of common shares (Note 10)			57,589			57,589		57,589
Contributions by noncontrolling interests							1,720	1,720
Net income				1,717,223		1,717,223		1,717,223
Net income allocated to noncontrolling interests				(6,192)		(6,192)	6,192	(6,192)
Distributions to equity holders:
Preferred shares (Note 8)				(216,316)		(216,316)		(216,316)
Noncontrolling interests							(7,022)	(7,022)
Common shareholders and restricted share unitholders ($8.00 per share)				(1,396,364)		(1,396,364)		(1,396,364)
Other comprehensive (loss) income (Note 2)					11,004	11,004		11,004
Balances at Dec. 31, 2018	4,025,000	17,413	5,718,485	(577,360)	(64,060)	9,119,478	25,250	9,144,728
Issuance of preferred shares (Note 8)	1,090,000					1,059,156		1,059,156
Issuance of preferred shares (Note 8), adjustment to APIC			(30,844)
Redemption of preferred shares (Note 8)	(1,050,000)					(1,050,000)		(1,050,000)
Issuance of common shares in connection with share-based compensation (Note 10)		29	33,535			33,564		33,564
Share-based compensation expense, net of cash paid in lieu of common shares (Note 10)			13,671			13,671		13,671
Acquisition of noncontrolling interests			(23,913)			(23,913)	(11,087)	(35,000)
Contributions by noncontrolling interests							4,148	4,148
Net income				1,525,651		1,525,651		1,525,651
Net income allocated to noncontrolling interests				(5,117)		(5,117)	5,117	(5,117)
Distributions to equity holders:
Preferred shares (Note 8)				(210,179)		(210,179)		(210,179)
Noncontrolling interests							(6,672)	(6,672)
Common shareholders and restricted share unitholders ($8.00 per share)				(1,398,570)		(1,398,570)		(1,398,570)
Other comprehensive (loss) income (Note 2)					(830)	(830)		(830)
Balances at Dec. 31, 2019	$ 4,065,000	$ 17,442	$ 5,710,934	$ (665,575)	$ (64,890)	$ 9,062,911	$ 16,756	$ 9,079,667