Statements Of Comprehensive Income - USD ($) $ in Thousands	12 Months Ended
	Dec. 31, 2019	Dec. 31, 2018	Dec. 31, 2017
Statements Of Comprehensive Income [Abstract]
Net income	$ 1,525,651	$ 1,717,223	$ 1,448,465
Other comprehensive income (loss):
Aggregate foreign currency exchange gain (loss)	6,999	1,914	(30,003)
Adjust for foreign currency exchange loss reflected in gain on sale of real estate and gain on Shurgard public offering		27,207
Adjust for aggregate foreign currency exchange (gain) loss included in net income	(7,829)	(18,117)	50,045
Other comprehensive (loss) income	(830)	11,004	20,042
Total comprehensive income	1,524,821	1,728,227	1,468,507
Allocation to noncontrolling interests	(5,117)	(6,192)	(6,248)
Comprehensive income allocable to Public Storage shareholders	$ 1,519,704	$ 1,722,035	$ 1,462,259