<?xml version="1.0"?>
<ownershipDocument>

    <schemaVersion>X0202</schemaVersion>

    <documentType>4</documentType>

    <periodOfReport>2008-02-26</periodOfReport>

    <issuer>
        <issuerCik>0000091142</issuerCik>
        <issuerName>SMITH A O CORP</issuerName>
        <issuerTradingSymbol>AOS</issuerTradingSymbol>
    </issuer>

    <reportingOwner>
        <reportingOwnerId>
            <rptOwnerCik>0001310176</rptOwnerCik>
            <rptOwnerName>Petrarca Mark A</rptOwnerName>
        </reportingOwnerId>
        <reportingOwnerAddress>
            <rptOwnerStreet1>A. O. SMITH CORPORATION</rptOwnerStreet1>
            <rptOwnerStreet2>11270 WEST PARK PLACE</rptOwnerStreet2>
            <rptOwnerCity>MILWAUKEE</rptOwnerCity>
            <rptOwnerState>WI</rptOwnerState>
            <rptOwnerZipCode>53224</rptOwnerZipCode>
            <rptOwnerStateDescription></rptOwnerStateDescription>
        </reportingOwnerAddress>
        <reportingOwnerRelationship>
            <isDirector>0</isDirector>
            <isOfficer>1</isOfficer>
            <isTenPercentOwner>0</isTenPercentOwner>
            <isOther>0</isOther>
            <officerTitle>Senior Vice Pres. - H.R. &amp; P.A</officerTitle>
        </reportingOwnerRelationship>
    </reportingOwner>

    <nonDerivativeTable>
        <nonDerivativeTransaction>
            <securityTitle>
                <value>Common Stock</value>
            </securityTitle>
            <transactionDate>
                <value>2008-02-26</value>
            </transactionDate>
            <transactionCoding>
                <transactionFormType>4</transactionFormType>
                <transactionCode>S</transactionCode>
                <equitySwapInvolved>0</equitySwapInvolved>
            </transactionCoding>
            <transactionAmounts>
                <transactionShares>
                    <value>.774</value>
                </transactionShares>
                <transactionPricePerShare>
                    <value>36.95</value>
                </transactionPricePerShare>
                <transactionAcquiredDisposedCode>
                    <value>D</value>
                </transactionAcquiredDisposedCode>
            </transactionAmounts>
            <postTransactionAmounts>
                <sharesOwnedFollowingTransaction>
                    <value>3227</value>
                    <footnoteId id="F1"/>
                </sharesOwnedFollowingTransaction>
            </postTransactionAmounts>
            <ownershipNature>
                <directOrIndirectOwnership>
                    <value>D</value>
                </directOrIndirectOwnership>
                <natureOfOwnership>
                    <value></value>
                </natureOfOwnership>
            </ownershipNature>
        </nonDerivativeTransaction>
    </nonDerivativeTable>

    <footnotes>
        <footnote id="F1">Column 5 of Table 1 includes 1.045 shares of Common Stock acquired through automatic reinvestment of quarterly dividends under the A. O. Smith Corporation Dividend Reinvestment Plan (&quot;Plan&quot;).  On February 26, 2008, Mark Petrarca ended his participation in this Plan and the fractional shares were sold.</footnote>
    </footnotes>

    <remarks></remarks>

    <ownerSignature>
        <signatureName>James F. Stern, Attorney-in-Fact for Mark A. Petrarca</signatureName>
        <signatureDate>2008-02-27</signatureDate>
    </ownerSignature>
</ownershipDocument>
