<?xml version="1.0"?>
<ownershipDocument>

    <schemaVersion>X0303</schemaVersion>

    <documentType>4</documentType>

    <periodOfReport>2010-01-28</periodOfReport>

    <issuer>
        <issuerCik>0000091142</issuerCik>
        <issuerName>SMITH A O CORP</issuerName>
        <issuerTradingSymbol>AOS</issuerTradingSymbol>
    </issuer>

    <reportingOwner>
        <reportingOwnerId>
            <rptOwnerCik>0001219555</rptOwnerCik>
            <rptOwnerName>MAPES CHRISTOPHER L</rptOwnerName>
        </reportingOwnerId>
        <reportingOwnerAddress>
            <rptOwnerStreet1>A. O. SMITH ELECTRICAL PRODUCTS COMPANY</rptOwnerStreet1>
            <rptOwnerStreet2>531 NORTH 4TH STREET</rptOwnerStreet2>
            <rptOwnerCity>TIPP CITY</rptOwnerCity>
            <rptOwnerState>OH</rptOwnerState>
            <rptOwnerZipCode>45371-1899</rptOwnerZipCode>
            <rptOwnerStateDescription></rptOwnerStateDescription>
        </reportingOwnerAddress>
        <reportingOwnerRelationship>
            <isDirector>0</isDirector>
            <isOfficer>1</isOfficer>
            <isTenPercentOwner>0</isTenPercentOwner>
            <isOther>0</isOther>
            <officerTitle>Executive Vice President</officerTitle>
        </reportingOwnerRelationship>
    </reportingOwner>

    <nonDerivativeTable>
        <nonDerivativeTransaction>
            <securityTitle>
                <value>Common Stock</value>
            </securityTitle>
            <transactionDate>
                <value>2010-01-28</value>
            </transactionDate>
            <transactionCoding>
                <transactionFormType>4</transactionFormType>
                <transactionCode>S</transactionCode>
                <equitySwapInvolved>0</equitySwapInvolved>
            </transactionCoding>
            <transactionAmounts>
                <transactionShares>
                    <value>.466</value>
                    <footnoteId id="F1"/>
                </transactionShares>
                <transactionPricePerShare>
                    <value>43.28</value>
                </transactionPricePerShare>
                <transactionAcquiredDisposedCode>
                    <value>D</value>
                </transactionAcquiredDisposedCode>
            </transactionAmounts>
            <postTransactionAmounts>
                <sharesOwnedFollowingTransaction>
                    <value>14975</value>
                </sharesOwnedFollowingTransaction>
            </postTransactionAmounts>
            <ownershipNature>
                <directOrIndirectOwnership>
                    <value>D</value>
                </directOrIndirectOwnership>
                <natureOfOwnership>
                    <value></value>
                </natureOfOwnership>
            </ownershipNature>
        </nonDerivativeTransaction>
    </nonDerivativeTable>

    <footnotes>
        <footnote id="F1">Column 5 of Table 1 includes 572 shares of Common Stock acquired through automatic reinvestment of quarterly dividends under the A. O. Corporation Dividend Reinvestment Plan (&quot;Plan&quot;).  On January 19, 2010, Christopher Mapes discontinued his participation in this Plan and the fractional shares were sold on January 28, 2010.</footnote>
    </footnotes>

    <remarks></remarks>

    <ownerSignature>
        <signatureName>Kenneth J. Maciolek, Attorney-in-Fact for Christopher L. Mapes</signatureName>
        <signatureDate>2010-02-01</signatureDate>
    </ownerSignature>
</ownershipDocument>
