<?xml version="1.0"?>
<ownershipDocument>

    <schemaVersion>X0303</schemaVersion>

    <documentType>4</documentType>

    <periodOfReport>2010-02-01</periodOfReport>

    <notSubjectToSection16>0</notSubjectToSection16>

    <issuer>
        <issuerCik>0000910322</issuerCik>
        <issuerName>ASTORIA FINANCIAL CORP</issuerName>
        <issuerTradingSymbol>AF</issuerTradingSymbol>
    </issuer>

    <reportingOwner>
        <reportingOwnerId>
            <rptOwnerCik>0001210743</rptOwnerCik>
            <rptOwnerName>CONEFRY JOHN J JR</rptOwnerName>
        </reportingOwnerId>
        <reportingOwnerAddress>
            <rptOwnerStreet1>ONE ASTORIA FEDERAL PLAZA</rptOwnerStreet1>
            <rptOwnerStreet2></rptOwnerStreet2>
            <rptOwnerCity>LAKE SUCCESS</rptOwnerCity>
            <rptOwnerState>NY</rptOwnerState>
            <rptOwnerZipCode>11042</rptOwnerZipCode>
            <rptOwnerStateDescription></rptOwnerStateDescription>
        </reportingOwnerAddress>
        <reportingOwnerRelationship>
            <isDirector>1</isDirector>
            <isOfficer>0</isOfficer>
            <isTenPercentOwner>0</isTenPercentOwner>
            <isOther>0</isOther>
        </reportingOwnerRelationship>
    </reportingOwner>

    <nonDerivativeTable>
        <nonDerivativeHolding>
            <securityTitle>
                <value>Common Stock</value>
            </securityTitle>
            <postTransactionAmounts>
                <sharesOwnedFollowingTransaction>
                    <value>49334</value>
                </sharesOwnedFollowingTransaction>
            </postTransactionAmounts>
            <ownershipNature>
                <directOrIndirectOwnership>
                    <value>D</value>
                    <footnoteId id="F1"/>
                </directOrIndirectOwnership>
            </ownershipNature>
        </nonDerivativeHolding>
        <nonDerivativeHolding>
            <securityTitle>
                <value>Common Stock</value>
            </securityTitle>
            <postTransactionAmounts>
                <sharesOwnedFollowingTransaction>
                    <value>1805</value>
                </sharesOwnedFollowingTransaction>
            </postTransactionAmounts>
            <ownershipNature>
                <directOrIndirectOwnership>
                    <value>I</value>
                    <footnoteId id="F2"/>
                </directOrIndirectOwnership>
                <natureOfOwnership>
                    <value>RSA</value>
                </natureOfOwnership>
            </ownershipNature>
        </nonDerivativeHolding>
        <nonDerivativeHolding>
            <securityTitle>
                <value>Common Stock</value>
            </securityTitle>
            <postTransactionAmounts>
                <sharesOwnedFollowingTransaction>
                    <value>5494</value>
                </sharesOwnedFollowingTransaction>
            </postTransactionAmounts>
            <ownershipNature>
                <directOrIndirectOwnership>
                    <value>I</value>
                    <footnoteId id="F3"/>
                </directOrIndirectOwnership>
                <natureOfOwnership>
                    <value>RSA</value>
                </natureOfOwnership>
            </ownershipNature>
        </nonDerivativeHolding>
        <nonDerivativeTransaction>
            <securityTitle>
                <value>Common Stock</value>
            </securityTitle>
            <transactionDate>
                <value>2010-02-01</value>
            </transactionDate>
            <transactionCoding>
                <transactionFormType>4</transactionFormType>
                <transactionCode>A</transactionCode>
                <equitySwapInvolved>0</equitySwapInvolved>
            </transactionCoding>
            <transactionTimeliness>
                <value></value>
            </transactionTimeliness>
            <transactionAmounts>
                <transactionShares>
                    <value>3461</value>
                </transactionShares>
                <transactionPricePerShare>
                    <value>0</value>
                </transactionPricePerShare>
                <transactionAcquiredDisposedCode>
                    <value>A</value>
                </transactionAcquiredDisposedCode>
            </transactionAmounts>
            <postTransactionAmounts>
                <sharesOwnedFollowingTransaction>
                    <value>3461</value>
                </sharesOwnedFollowingTransaction>
            </postTransactionAmounts>
            <ownershipNature>
                <directOrIndirectOwnership>
                    <value>I</value>
                    <footnoteId id="F4"/>
                </directOrIndirectOwnership>
                <natureOfOwnership>
                    <value>RSA</value>
                </natureOfOwnership>
            </ownershipNature>
        </nonDerivativeTransaction>
    </nonDerivativeTable>

    <derivativeTable>
        <derivativeHolding>
            <securityTitle>
                <value>Non-Statutory Stock Option</value>
                <footnoteId id="F5"/>
            </securityTitle>
            <conversionOrExercisePrice>
                <value>24.1667</value>
            </conversionOrExercisePrice>
            <exerciseDate>
                <value>2004-01-15</value>
            </exerciseDate>
            <expirationDate>
                <value>2014-01-14</value>
            </expirationDate>
            <underlyingSecurity>
                <underlyingSecurityTitle>
                    <value>Common Stock</value>
                </underlyingSecurityTitle>
                <underlyingSecurityShares>
                    <value>6000</value>
                </underlyingSecurityShares>
            </underlyingSecurity>
            <postTransactionAmounts>
                <sharesOwnedFollowingTransaction>
                    <value>6000</value>
                </sharesOwnedFollowingTransaction>
            </postTransactionAmounts>
            <ownershipNature>
                <directOrIndirectOwnership>
                    <value>D</value>
                </directOrIndirectOwnership>
            </ownershipNature>
        </derivativeHolding>
        <derivativeHolding>
            <securityTitle>
                <value>Non-Statutory Stock Option</value>
                <footnoteId id="F5"/>
            </securityTitle>
            <conversionOrExercisePrice>
                <value>26.2333</value>
            </conversionOrExercisePrice>
            <exerciseDate>
                <value>2005-01-18</value>
            </exerciseDate>
            <expirationDate>
                <value>2015-01-17</value>
            </expirationDate>
            <underlyingSecurity>
                <underlyingSecurityTitle>
                    <value>Common Stock</value>
                </underlyingSecurityTitle>
                <underlyingSecurityShares>
                    <value>6000</value>
                </underlyingSecurityShares>
            </underlyingSecurity>
            <postTransactionAmounts>
                <sharesOwnedFollowingTransaction>
                    <value>6000</value>
                </sharesOwnedFollowingTransaction>
            </postTransactionAmounts>
            <ownershipNature>
                <directOrIndirectOwnership>
                    <value>D</value>
                </directOrIndirectOwnership>
            </ownershipNature>
        </derivativeHolding>
        <derivativeHolding>
            <securityTitle>
                <value>Non-Statutory Stock Option</value>
                <footnoteId id="F5"/>
            </securityTitle>
            <conversionOrExercisePrice>
                <value>29.79</value>
            </conversionOrExercisePrice>
            <exerciseDate>
                <value>2006-01-17</value>
            </exerciseDate>
            <expirationDate>
                <value>2016-01-16</value>
            </expirationDate>
            <underlyingSecurity>
                <underlyingSecurityTitle>
                    <value>Common Stock</value>
                </underlyingSecurityTitle>
                <underlyingSecurityShares>
                    <value>6000</value>
                </underlyingSecurityShares>
            </underlyingSecurity>
            <postTransactionAmounts>
                <sharesOwnedFollowingTransaction>
                    <value>6000</value>
                </sharesOwnedFollowingTransaction>
            </postTransactionAmounts>
            <ownershipNature>
                <directOrIndirectOwnership>
                    <value>D</value>
                </directOrIndirectOwnership>
            </ownershipNature>
        </derivativeHolding>
        <derivativeHolding>
            <securityTitle>
                <value>Non-Statutory Stock Option</value>
                <footnoteId id="F5"/>
            </securityTitle>
            <conversionOrExercisePrice>
                <value>29.72</value>
            </conversionOrExercisePrice>
            <exerciseDate>
                <value>2007-01-16</value>
            </exerciseDate>
            <expirationDate>
                <value>2017-01-15</value>
            </expirationDate>
            <underlyingSecurity>
                <underlyingSecurityTitle>
                    <value>Common Stock</value>
                </underlyingSecurityTitle>
                <underlyingSecurityShares>
                    <value>6000</value>
                </underlyingSecurityShares>
            </underlyingSecurity>
            <postTransactionAmounts>
                <sharesOwnedFollowingTransaction>
                    <value>6000</value>
                </sharesOwnedFollowingTransaction>
            </postTransactionAmounts>
            <ownershipNature>
                <directOrIndirectOwnership>
                    <value>D</value>
                </directOrIndirectOwnership>
            </ownershipNature>
        </derivativeHolding>
    </derivativeTable>

    <footnotes>
        <footnote id="F1">Represents shares held in Mr. Conefry, Jr.'s Simplified Employer Pension Plan (&quot;SEP Plan&quot;).</footnote>
        <footnote id="F2">Represents award of restricted stock pursuant to the Astoria Financial Corporation 2007 Non-Employee Director Stock Plan, or the 2007 Plan. The restricted stock will vest and be distributed effective January 28, 2011 or earlier upon the death, disability or Mandatory Retirement, on a Change in Control, or Involuntary Termination, all as specified in the 2007 Plan.</footnote>
        <footnote id="F3">Represents award of restricted stock pursuant to the Astoria Financial Corporation 2007 Non-Employee Director Stock Plan, or the 2007 Plan. The restricted stock will vest and be distributed effective February 2, 2012 or earlier upon the death, disability or Mandatory Retirement, on a Change in Control, or Involuntary Termination, all as specified in the 2007 Plan.</footnote>
        <footnote id="F4">Represents award of restricted stock pursuant to the Astoria Financial Corporation 2007 Non-Employee Director Stock Plan, or the 2007 Plan. The restricted stock will vest and be distributed effective February 1, 2013 or earlier upon the death, disability or Mandatory Retirement, on a Change in Control, or Involuntary Termination, all as specified in the 2007 Plan.</footnote>
        <footnote id="F5">Options were granted pursuant to the 1999 Stock Option Plan for Outside Directors of Astoria Financial Corporation, or the 1999 Plan.</footnote>
    </footnotes>

    <ownerSignature>
        <signatureName>John J. Conefry, Jr. by Alan P. Eggleston, attorney-in-fact</signatureName>
        <signatureDate>2010-02-02</signatureDate>
    </ownerSignature>
</ownershipDocument>
