<?xml version="1.0"?>
<ownershipDocument>

    <schemaVersion>X0303</schemaVersion>

    <documentType>4/A</documentType>

    <periodOfReport>2010-06-11</periodOfReport>

    <dateOfOriginalSubmission>2010-06-14</dateOfOriginalSubmission>

    <issuer>
        <issuerCik>0000883902</issuerCik>
        <issuerName>NCI BUILDING SYSTEMS INC</issuerName>
        <issuerTradingSymbol>NCS</issuerTradingSymbol>
    </issuer>

    <reportingOwner>
        <reportingOwnerId>
            <rptOwnerCik>0001205070</rptOwnerCik>
            <rptOwnerName>CHAMBERS NORMAN C</rptOwnerName>
        </reportingOwnerId>
        <reportingOwnerAddress>
            <rptOwnerStreet1>10943 NORTH SAM HOUSTON PARKWAY WEST</rptOwnerStreet1>
            <rptOwnerStreet2></rptOwnerStreet2>
            <rptOwnerCity>HOUSTON</rptOwnerCity>
            <rptOwnerState>TX</rptOwnerState>
            <rptOwnerZipCode>77064</rptOwnerZipCode>
            <rptOwnerStateDescription></rptOwnerStateDescription>
        </reportingOwnerAddress>
        <reportingOwnerRelationship>
            <isDirector>1</isDirector>
            <isOfficer>1</isOfficer>
            <isTenPercentOwner>0</isTenPercentOwner>
            <isOther>0</isOther>
            <officerTitle>Chairman, President &amp; CEO</officerTitle>
        </reportingOwnerRelationship>
    </reportingOwner>

    <nonDerivativeTable>
        <nonDerivativeTransaction>
            <securityTitle>
                <value>Common Stock, $0.01 par value</value>
            </securityTitle>
            <transactionDate>
                <value>2010-06-11</value>
            </transactionDate>
            <transactionCoding>
                <transactionFormType>4</transactionFormType>
                <transactionCode>P</transactionCode>
                <equitySwapInvolved>0</equitySwapInvolved>
            </transactionCoding>
            <transactionAmounts>
                <transactionShares>
                    <value>95538</value>
                    <footnoteId id="F3"/>
                </transactionShares>
                <transactionPricePerShare>
                    <value>8.56</value>
                </transactionPricePerShare>
                <transactionAcquiredDisposedCode>
                    <value>A</value>
                </transactionAcquiredDisposedCode>
            </transactionAmounts>
            <postTransactionAmounts>
                <sharesOwnedFollowingTransaction>
                    <value>338152</value>
                    <footnoteId id="F2"/>
                </sharesOwnedFollowingTransaction>
            </postTransactionAmounts>
            <ownershipNature>
                <directOrIndirectOwnership>
                    <value>D</value>
                </directOrIndirectOwnership>
                <natureOfOwnership>
                    <value></value>
                </natureOfOwnership>
            </ownershipNature>
        </nonDerivativeTransaction>
        <nonDerivativeHolding>
            <securityTitle>
                <value>Common Stock, $0.01 par value</value>
            </securityTitle>
            <postTransactionAmounts>
                <sharesOwnedFollowingTransaction>
                    <value>985</value>
                    <footnoteId id="F1"/>
                </sharesOwnedFollowingTransaction>
            </postTransactionAmounts>
            <ownershipNature>
                <directOrIndirectOwnership>
                    <value>I</value>
                </directOrIndirectOwnership>
                <natureOfOwnership>
                    <value>NCI 401(k) Plan.</value>
                </natureOfOwnership>
            </ownershipNature>
        </nonDerivativeHolding>
    </nonDerivativeTable>

    <footnotes>
        <footnote id="F1">Holdings in 401(k) plan calculated as of June 10, 2010.  Effective March 5, 2010, the common stock of NCI Building Systems, Inc. underwent a reverse split at a 1-for-5 ratio, resulting in a reduction of the reporting person's shares at that time.</footnote>
        <footnote id="F2">Effective March 5, 2010, the common stock of NCI Building Systems, Inc. underwent a reverse split at a 1-for-5 ratio, resulting in a reduction of the reporting person's shares at that time.</footnote>
        <footnote id="F3">Due to an incomplete accounting of the funds from which shares of NCI common stock were purchased, the Form 4 filed on June 14, 2010 incorrectly reported a purchase of 95,516 shares, 22 shares less than were ultimately purchased.</footnote>
    </footnotes>

    <remarks></remarks>

    <ownerSignature>
        <signatureName>Todd R. Moore (by power of attorney)</signatureName>
        <signatureDate>2010-06-15</signatureDate>
    </ownerSignature>
</ownershipDocument>
