Basis Of Presentation (Narrative) (Details)	3 Months Ended	6 Months Ended
	Jun. 30, 2019 USD ($) shares	Jun. 30, 2019 USD ($) shares	Jun. 30, 2018 USD ($)	Mar. 31, 2019 USD ($)	Jan. 01, 2019 USD ($)	Dec. 31, 2018 USD ($)	Apr. 02, 2018	Mar. 31, 2018 USD ($)	Jan. 01, 2018 USD ($)	Dec. 31, 2017 USD ($)	Dec. 31, 2016 USD ($) hotel
Noncontrolling Interest [Abstract]
Net income (loss) attributable to nonredeemable noncontrolling interest	$ 0	$ 300,000
Change in redemption value		148,000	$ 0
Equity in noncontrolling interest	912,063,000	$ 912,063,000				$ 954,815,000
Stockholders' Equity, Number of Shares, Par Value and Other Disclosures [Abstract]
Stock repurchase program, authorized amount						50,000,000
Common shares repurchased (in shares) | shares		273,538,000
Common shares repurchased		$ 4,624,000
Revenue from Contract with Customer [Abstract]
Deferred Gain on Disposition of Hotel Assets										$ 81,284,000
Cumulative Effect on Equity from the Adoption of ASC Subtopic 610-20	0	0	129,021,000
Distributions in Excess of Net Income	302,705,000	302,705,000				267,740,000				335,373,000
Stockholders' equity attributable to noncontrolling interest	(64,574,000)	(64,574,000)				(62,010,000)				(54,286,000)
Right of use asset	45,990,000	45,990,000
Lease liability	54,861,000	54,861,000
Decrease in intangible assets	(2,333,000)	(2,333,000)				(13,644,000)
Decrease in accounts payable and accrued expenses	$ (50,070,000)	$ (50,070,000)				(70,947,000)
Weighted average remaining lease term	64 years 2 months 12 days	64 years 2 months 12 days			64 years 2 months 12 days
Noncontrolling Interests Common Units And LTIP Units [Member]
Noncontrolling Interest [Abstract]
Noncontrolling interests in Nonredeemable Common Units	$ 64,574,000	$ 64,574,000				62,010,000
Nonredeemable common units outstanding (in shares) | shares	4,279,946	4,279,946
Fair market value of nonredeemable common units	$ 70,790,000	$ 70,790,000
Equity in noncontrolling interest	64,574,000	64,574,000	63,117,000	$ 64,808,000		62,010,000		$ 63,027,000		54,286,000
Revenue from Contract with Customer [Abstract]
Cumulative Effect on Equity from the Adoption of ASC Subtopic 610-20									$ 5,793,000
Additional Paid-In Capital [Member]
Noncontrolling Interest [Abstract]
Change in redemption value	8,000	148,000
Equity in noncontrolling interest	1,152,939,000	1,152,939,000	1,156,604,000	1,151,654,000		1,155,776,000		1,154,904,000		1,164,946,000
Consolidated Joint Ventures [Member]
Noncontrolling Interest [Abstract]
Change in redemption value	(8,000)	(148,000)
Equity in noncontrolling interest	2,856,000	2,856,000	$ 2,186,000	$ 2,848,000		$ 2,708,000		$ 0		$ 0
Accounting Standards Update 2014-09 [Member]
Revenue from Contract with Customer [Abstract]
Number of real estate properties | hotel											7
Deferred Gain on Disposition of Hotel Assets											$ 81,000,000
Accounting Standards Update 2017-05 [Member]
Revenue from Contract with Customer [Abstract]
Deferred Gain on Disposition of Hotel Assets									0
Distributions in Excess of Net Income									212,145,000
Stockholders' equity attributable to noncontrolling interest									(60,079,000)
Accounting Standards Update 2017-05 [Member] | Pro Forma [Member]
Revenue from Contract with Customer [Abstract]
Deferred Gain on Disposition of Hotel Assets	129,021,000	129,021,000
Distributions in Excess of Net Income	123,228,000	123,228,000
Stockholders' equity attributable to noncontrolling interest	$ 5,793,000	$ 5,793,000
Accounting Standards Update 2017-05 [Member] | Retained Earnings [Member]
Revenue from Contract with Customer [Abstract]
Cumulative Effect on Equity from the Adoption of ASC Subtopic 610-20									123,228,000
Accounting Standards Update 2017-05 [Member] | Noncontrolling Interest [Member]
Revenue from Contract with Customer [Abstract]
Cumulative Effect on Equity from the Adoption of ASC Subtopic 610-20									$ 5,793,000
Accounting Standards Update 2016-02 [Member]
Revenue from Contract with Customer [Abstract]
Right of use asset					$ 55,515,000
Lease liability					55,515,000
Decrease in accounts payable and accrued expenses					19,627,000
Senior Common Equity Interest [Member]
Noncontrolling Interest [Abstract]
Noncontrolling interest, common equity interest, return		12.00%
Hersha Hospitality Limited Partnership [Member]
Class of Stock [Line Items]
General partnership interest (in hundredths)		1.00%
Consolidated Joint Ventures [Member]
Noncontrolling Interest [Abstract]
Noncontrolling interest, ownership percentage							15.00%
Cumulative return on common equity interest	30.00%	30.00%
Consolidated Joint Ventures [Member] | Senior Common Equity Interest [Member]
Noncontrolling Interest [Abstract]
Cumulative return on common equity interest	25.00%	25.00%
Consolidated Joint Ventures [Member] | Junior Common Equity Interest [Member] | Scenario, Plan [Member]
Noncontrolling Interest [Abstract]
Noncontrolling interest, common equity interest, return		8.00%
Hersha Holding RC Owner, LLC [Member]
Noncontrolling Interest [Abstract]
Cumulative return on common equity interest	70.00%	70.00%
Hersha Holding RC Owner, LLC [Member] | Senior Common Equity Interest [Member]
Noncontrolling Interest [Abstract]
Noncontrolling interest, common equity interest, return		8.00%
Cumulative return on common equity interest	75.00%	75.00%
Hersha Hospitality Limited Partnership [Member]
Class of Stock [Line Items]
Approximate ownership percentage in the partnership (in hundredths)	90.20%	90.20%
Market Rate Lease [Member] | Accounting Standards Update 2016-02 [Member]
Revenue from Contract with Customer [Abstract]
Decrease in intangible assets					$ 11,050,000