<?xml version="1.0"?>
<ownershipDocument>

    <schemaVersion>X0305</schemaVersion>

    <documentType>4</documentType>

    <periodOfReport>2012-04-16</periodOfReport>

    <issuer>
        <issuerCik>0000091142</issuerCik>
        <issuerName>SMITH A O CORP</issuerName>
        <issuerTradingSymbol>AOS</issuerTradingSymbol>
    </issuer>

    <reportingOwner>
        <reportingOwnerId>
            <rptOwnerCik>0001196442</rptOwnerCik>
            <rptOwnerName>WOLF IDELLE K</rptOwnerName>
        </reportingOwnerId>
        <reportingOwnerAddress>
            <rptOwnerStreet1>A. O. SMITH CORPORATION</rptOwnerStreet1>
            <rptOwnerStreet2>11270 WEST PARK PLACE</rptOwnerStreet2>
            <rptOwnerCity>MILWAUKEE</rptOwnerCity>
            <rptOwnerState>WI</rptOwnerState>
            <rptOwnerZipCode>53224</rptOwnerZipCode>
            <rptOwnerStateDescription></rptOwnerStateDescription>
        </reportingOwnerAddress>
        <reportingOwnerRelationship>
            <isDirector>1</isDirector>
            <isOfficer>0</isOfficer>
            <isTenPercentOwner>0</isTenPercentOwner>
            <isOther>0</isOther>
        </reportingOwnerRelationship>
    </reportingOwner>

    <derivativeTable>
        <derivativeTransaction>
            <securityTitle>
                <value>Restricted Stock Units</value>
                <footnoteId id="F1"/>
            </securityTitle>
            <conversionOrExercisePrice>
                <value>44.24</value>
            </conversionOrExercisePrice>
            <transactionDate>
                <value>2012-04-16</value>
            </transactionDate>
            <transactionCoding>
                <transactionFormType>4</transactionFormType>
                <transactionCode>A</transactionCode>
                <equitySwapInvolved>0</equitySwapInvolved>
            </transactionCoding>
            <transactionAmounts>
                <transactionShares>
                    <value>2035</value>
                </transactionShares>
                <transactionPricePerShare>
                    <value>0</value>
                </transactionPricePerShare>
                <transactionAcquiredDisposedCode>
                    <value>A</value>
                </transactionAcquiredDisposedCode>
            </transactionAmounts>
            <exerciseDate>
                <footnoteId id="F2"/>
            </exerciseDate>
            <expirationDate>
                <footnoteId id="F2"/>
            </expirationDate>
            <underlyingSecurity>
                <underlyingSecurityTitle>
                    <value>Common Stock</value>
                </underlyingSecurityTitle>
                <underlyingSecurityShares>
                    <value>2035</value>
                </underlyingSecurityShares>
            </underlyingSecurity>
            <postTransactionAmounts>
                <sharesOwnedFollowingTransaction>
                    <value>2035</value>
                </sharesOwnedFollowingTransaction>
            </postTransactionAmounts>
            <ownershipNature>
                <directOrIndirectOwnership>
                    <value>D</value>
                </directOrIndirectOwnership>
                <natureOfOwnership>
                    <value></value>
                </natureOfOwnership>
            </ownershipNature>
        </derivativeTransaction>
    </derivativeTable>

    <footnotes>
        <footnote id="F1">Payment of portion of retainer in Restricted Stock Units under the A. O. Smith Nonqualified Deferred Compensation Plan based on the market price of the Common Stock on April 16, 2012.</footnote>
        <footnote id="F2">The Plan permits the participant to defer the receipt of the award, and Ms. Wolf has made a deferral.</footnote>
    </footnotes>

    <remarks></remarks>

    <ownerSignature>
        <signatureName>James F. Stern, Attorney-in-Fact for Idelle K. Wolf</signatureName>
        <signatureDate>2012-04-17</signatureDate>
    </ownerSignature>
</ownershipDocument>
